notkshitij/docker-credential-helpers
1
0
Fork 0
mirror of https://github.com/docker/docker-credential-helpers.git synced 2026-06-13 16:01:28 +05:30
Code Releases 1 Activity

removed a semicolon and the placeholder for the error which we used to locate it. Seems like SecItemCopyMatching is giving an error for some reason- no error on local machine

Browse Source 
Signed-off-by: avaid96 <avaid1996@gmail.com>
This commit is contained in:
avaid96
2016-07-13 14:36:14 -07:00
parent 8fa18eb16c
commit 029e094488
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osxkeychain/osxkeychain_darwin.go
-1
View File
@@ -104,7 +104,6 @@ func (h Osxkeychain) List() ([]string, []string, error) {
if errMsg != nil { if errMsg != nil {
defer C.free(unsafe.Pointer(errMsg)) defer C.free(unsafe.Pointer(errMsg))
goMsg := C.GoString(errMsg) goMsg := C.GoString(errMsg)
goMsg = "Error is here"
return nil, nil, errors.New(goMsg) return nil, nil, errors.New(goMsg)
} }
var listLen int var listLen int
osxkeychain/osxkeychain_darwin_test.go
+2 -2
View File
@@ -37,18 +37,18 @@ func TestOSXKeychainHelper(t *testing.T) {
if err := helper.Delete(creds.ServerURL); err != nil { if err := helper.Delete(creds.ServerURL); err != nil {
t.Fatal(err) t.Fatal(err)
} }
helper.Add(creds); helper.Add(creds)
defer helper.Delete(creds.ServerURL) defer helper.Delete(creds.ServerURL)
paths, accts, err := helper.List() paths, accts, err := helper.List()
if err != nil || len(paths) == 0 || len(accts) == 0 { if err != nil || len(paths) == 0 || len(accts) == 0 {
t.Fatal(err) t.Fatal(err)
} }
helper.Add(creds1) helper.Add(creds1)
defer helper.Delete(creds1.ServerURL)
newpaths, newaccts, err := helper.List() newpaths, newaccts, err := helper.List()
if len(newpaths)-len(paths) != 1 || len(newaccts)-len(accts) != 1 { if len(newpaths)-len(paths) != 1 || len(newaccts)-len(accts) != 1 {
t.Fatal(err) t.Fatal(err)
} }
helper.Delete(creds1.ServerURL)
} }
func TestMissingCredentials(t *testing.T) { func TestMissingCredentials(t *testing.T) {