notkshitij/docker-credential-helpers
1
0
Fork 0
mirror of https://github.com/docker/docker-credential-helpers.git synced 2026-06-14 16:31:45 +05:30
Code Releases 1 Activity

Move away from password as a name. We store secrets.

Browse Source 
Signed-off-by: David Calavera <david.calavera@gmail.com>
This commit is contained in:
David Calavera
2016-03-09 15:18:48 -05:00
parent 0fb2225199
commit 2275377a31
14 changed files with 59 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osxkeychain/osxkeychain_darwin.c
+5 -5
View File
@@ -10,7 +10,7 @@ char *get_error(OSStatus status) {
return buf;
}
char *keychain_add(struct Server *server, char *username, char *password) {
char *keychain_add(struct Server *server, char *username, char *secret) {
OSStatus status = SecKeychainAddInternetPassword(
NULL,
strlen(server->host), server->host,
@@ -20,7 +20,7 @@ char *keychain_add(struct Server *server, char *username, char *password) {
server->port,
server->proto,
kSecAuthenticationTypeDefault,
strlen(password), password,
strlen(secret), secret,
NULL
);
if (status) {
@@ -29,7 +29,7 @@ char *keychain_add(struct Server *server, char *username, char *password) {
return NULL;
}
char *keychain_get(struct Server *server, unsigned int *username_l, char **username, unsigned int *password_l, char **password) {
char *keychain_get(struct Server *server, unsigned int *username_l, char **username, unsigned int *secret_l, char **secret) {
char *tmp;
SecKeychainItemRef item;
@@ -42,14 +42,14 @@ char *keychain_get(struct Server *server, unsigned int *username_l, char **usern
server->port,
server->proto,
kSecAuthenticationTypeDefault,
password_l, (void **)&tmp,
secret_l, (void **)&tmp,
&item);
if (status) {
return get_error(status);
}
*password = strdup(tmp);
*secret = strdup(tmp);
SecKeychainItemFreeContent(NULL, tmp);
SecKeychainAttributeList list;