notkshitij/docker-credential-helpers
1
0
Fork 0
mirror of https://github.com/docker/docker-credential-helpers.git synced 2026-06-14 00:11:28 +05:30
Code Releases 1 Activity

Move away from password as a name. We store secrets.

Browse Source 
Signed-off-by: David Calavera <david.calavera@gmail.com>
This commit is contained in:
David Calavera
2016-03-09 15:18:48 -05:00
parent 0fb2225199
commit 2275377a31
14 changed files with 59 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files
secretservice/secretservice_linux.c
+7 -7
View File
@@ -15,11 +15,11 @@ const SecretSchema *docker_get_schema(void)
return &docker_schema;
}
GError *add(char *server, char *username, char *password) {
GError *add(char *server, char *username, char *secret) {
GError *err = NULL;
secret_password_store_sync (DOCKER_SCHEMA, SECRET_COLLECTION_DEFAULT,
server, password, NULL, &err,
server, secret, NULL, &err,
"server", server,
"username", username,
"docker_cli", "1",
@@ -54,13 +54,13 @@ char *get_username(SecretItem *item) {
return NULL;
}
GError *get(char *server, char **username, char **password) {
GError *get(char *server, char **username, char **secret) {
GError *err = NULL;
GHashTable *attributes;
SecretService *service;
GList *items, *l;
SecretSearchFlags flags = SECRET_SEARCH_LOAD_SECRETS | SECRET_SEARCH_ALL | SECRET_SEARCH_UNLOCK;
SecretValue *secret;
SecretValue *secretValue;
gsize length;
gchar *value;
@@ -79,10 +79,10 @@ GError *get(char *server, char **username, char **password) {
continue;
}
g_free(value);
secret = secret_item_get_secret(l->data);
secretValue = secret_item_get_secret(l->data);
if (secret != NULL) {
*password = strdup(secret_value_get(secret, &length));
secret_value_unref(secret);
*secret = strdup(secret_value_get(secretValue, &length));
secret_value_unref(secretValue);
}
*username = get_username(l->data);
}