1
0
mirror of https://github.com/docker/docker-credential-helpers.git synced 2026-06-13 16:01:28 +05:30

Move away from password as a name. We store secrets.

Signed-off-by: David Calavera <david.calavera@gmail.com>
This commit is contained in:
David Calavera
2016-03-09 15:18:48 -05:00
parent 0fb2225199
commit 2275377a31
14 changed files with 59 additions and 59 deletions
+1 -1
View File
@@ -16,7 +16,7 @@ func New() credentials.Helper {
func (h wincred) Add(creds *credentials.Credentials) error {
g := winc.NewGenericCredential(creds.ServerURL)
g.UserName = creds.Username
g.CredentialBlob = []byte(creds.Password)
g.CredentialBlob = []byte(creds.Secret)
g.Persist = winc.PersistLocalMachine
return g.Write()
}
+4 -4
View File
@@ -10,7 +10,7 @@ func TestWinCredHelper(t *testing.T) {
creds := &credentials.Credentials{
ServerURL: "https://foobar.docker.io:2376/v1",
Username: "foobar",
Password: "foobarbaz",
Secret: "foobarbaz",
}
helper := New()
@@ -18,7 +18,7 @@ func TestWinCredHelper(t *testing.T) {
t.Fatal(err)
}
username, password, err := helper.Get(creds.ServerURL)
username, secret, err := helper.Get(creds.ServerURL)
if err != nil {
t.Fatal(err)
}
@@ -27,8 +27,8 @@ func TestWinCredHelper(t *testing.T) {
t.Fatalf("expected %s, got %s\n", "foobar", username)
}
if password != "foobarbaz" {
t.Fatalf("expected %s, got %s\n", "foobarbaz", password)
if secret != "foobarbaz" {
t.Fatalf("expected %s, got %s\n", "foobarbaz", secret)
}
if err := helper.Delete(creds.ServerURL); err != nil {