notkshitij/docker-credential-helpers
1
0
Fork 0
mirror of https://github.com/docker/docker-credential-helpers.git synced 2026-06-13 16:01:28 +05:30
Code Releases 1 Activity

wincred: use sub-tests

Browse Source 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2023-05-27 15:38:24 +02:00
parent 814dbb3b5a
commit 7a60d70114
1 changed files with 47 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
wincred/wincred_windows_test.go
+13 -8
View File
@@ -129,10 +129,11 @@ func TestWinCredHelperRetrieveAliases(t *testing.T) {
} }
for _, tc := range tests { for _, tc := range tests {
tc := tc
t.Run(tc.doc, func(t *testing.T) {
c := &credentials.Credentials{ServerURL: tc.storeURL, Username: "hello", Secret: "world"} c := &credentials.Credentials{ServerURL: tc.storeURL, Username: "hello", Secret: "world"}
if err := helper.Add(c); err != nil { if err := helper.Add(c); err != nil {
t.Errorf("Error: failed to store secret for URL %q: %s", tc.storeURL, err) t.Fatalf("Error: failed to store secret for URL %q: %s", tc.storeURL, err)
continue
} }
if _, _, err := helper.Get(tc.readURL); err != nil { if _, _, err := helper.Get(tc.readURL); err != nil {
t.Errorf("Error: failed to read secret for URL %q using %q", tc.storeURL, tc.readURL) t.Errorf("Error: failed to read secret for URL %q using %q", tc.storeURL, tc.readURL)
@@ -140,6 +141,7 @@ func TestWinCredHelperRetrieveAliases(t *testing.T) {
if err := helper.Delete(tc.storeURL); err != nil { if err := helper.Delete(tc.storeURL); err != nil {
t.Error(err) t.Error(err)
} }
})
} }
} }
@@ -202,10 +204,11 @@ func TestWinCredHelperRetrieveStrict(t *testing.T) {
} }
for _, tc := range tests { for _, tc := range tests {
tc := tc
t.Run(tc.doc, func(t *testing.T) {
c := &credentials.Credentials{ServerURL: tc.storeURL, Username: "hello", Secret: "world"} c := &credentials.Credentials{ServerURL: tc.storeURL, Username: "hello", Secret: "world"}
if err := helper.Add(c); err != nil { if err := helper.Add(c); err != nil {
t.Errorf("Error: failed to store secret for URL %q: %s", tc.storeURL, err) t.Fatalf("Error: failed to store secret for URL %q: %s", tc.storeURL, err)
continue
} }
if _, _, err := helper.Get(tc.readURL); err == nil { if _, _, err := helper.Get(tc.readURL); err == nil {
t.Errorf("Error: managed to read secret for URL %q using %q, but should not be able to", tc.storeURL, tc.readURL) t.Errorf("Error: managed to read secret for URL %q using %q, but should not be able to", tc.storeURL, tc.readURL)
@@ -213,6 +216,7 @@ func TestWinCredHelperRetrieveStrict(t *testing.T) {
if err := helper.Delete(tc.storeURL); err != nil { if err := helper.Delete(tc.storeURL); err != nil {
t.Error(err) t.Error(err)
} }
})
} }
} }
@@ -251,6 +255,8 @@ func TestWinCredHelperStoreRetrieve(t *testing.T) {
// Note that we don't delete between individual tests here, to verify that // Note that we don't delete between individual tests here, to verify that
// subsequent stores/overwrites don't affect storing / retrieving secrets. // subsequent stores/overwrites don't affect storing / retrieving secrets.
for i, tc := range tests { for i, tc := range tests {
tc := tc
t.Run(tc.url, func(t *testing.T) {
c := &credentials.Credentials{ c := &credentials.Credentials{
ServerURL: tc.url, ServerURL: tc.url,
Username: fmt.Sprintf("user-%d", i), Username: fmt.Sprintf("user-%d", i),
@@ -258,13 +264,11 @@ func TestWinCredHelperStoreRetrieve(t *testing.T) {
} }
if err := helper.Add(c); err != nil { if err := helper.Add(c); err != nil {
t.Errorf("Error: failed to store secret for URL: %s: %s", tc.url, err) t.Fatalf("Error: failed to store secret for URL: %s: %s", tc.url, err)
continue
} }
user, secret, err := helper.Get(tc.url) user, secret, err := helper.Get(tc.url)
if err != nil { if err != nil {
t.Errorf("Error: failed to read secret for URL %q: %s", tc.url, err) t.Fatalf("Error: failed to read secret for URL %q: %s", tc.url, err)
continue
} }
if user != c.Username { if user != c.Username {
t.Errorf("Error: expected username %s, got username %s for URL: %s", c.Username, user, tc.url) t.Errorf("Error: expected username %s, got username %s for URL: %s", c.Username, user, tc.url)
@@ -272,6 +276,7 @@ func TestWinCredHelperStoreRetrieve(t *testing.T) {
if secret != c.Secret { if secret != c.Secret {
t.Errorf("Error: expected secret %s, got secret %s for URL: %s", c.Secret, secret, tc.url) t.Errorf("Error: expected secret %s, got secret %s for URL: %s", c.Secret, secret, tc.url)
} }
})
} }
} }