From c7514a0999c4c62ca574057f6b84819d303454c5 Mon Sep 17 00:00:00 2001 From: Albin Kerouanton Date: Fri, 28 Feb 2025 09:53:01 +0100 Subject: [PATCH] osxkeychain: list: do not error out when keychain is empty Commit 4cdcdc2 replaced the in-tree Objective-C code with github.com/keybase/go-keychain and inadvertently introduced a new failure mode on the `List` operation - it now fails when the keychain is empty. Before: ``` $ ./bin/build/docker-credential-osxkeychain list {} ``` After: ``` $ ./bin/build/docker-credential-osxkeychain list credentials not found in native keychain ``` Signed-off-by: Albin Kerouanton --- osxkeychain/osxkeychain.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/osxkeychain/osxkeychain.go b/osxkeychain/osxkeychain.go index 044eedb..1dfa2a5 100644 --- a/osxkeychain/osxkeychain.go +++ b/osxkeychain/osxkeychain.go @@ -117,8 +117,6 @@ func (h Osxkeychain) List() (map[string]string, error) { default: return nil, err } - } else if len(res) == 0 { - return nil, credentials.NewErrCredentialsNotFound() } resp := make(map[string]string)