1
0
mirror of https://github.com/docker/docker-credential-helpers.git synced 2026-06-13 16:01:28 +05:30

Publish helper structs and methods.

Signed-off-by: David Calavera <david.calavera@gmail.com>
This commit is contained in:
David Calavera
2016-03-24 15:08:17 -07:00
parent 4b8917b1cf
commit df8c7a02f1
9 changed files with 25 additions and 37 deletions
+1 -1
View File
@@ -6,5 +6,5 @@ import (
)
func main() {
credentials.Serve(secretservice.New())
credentials.Serve(secretservice.Secretservice{})
}
+6 -10
View File
@@ -14,15 +14,11 @@ import (
"github.com/docker/docker-credential-helpers/credentials"
)
type secretservice struct{}
// New creates a new secretservice.
func New() credentials.Helper {
return secretservice{}
}
// Secretservice handles secrets using Linux secret-service as a store.
type Secretservice struct{}
// Add adds new credentials to the keychain.
func (h secretservice) Add(creds *credentials.Credentials) error {
func (h Secretservice) Add(creds *credentials.Credentials) error {
if creds == nil {
return errors.New("missing credentials")
}
@@ -41,8 +37,8 @@ func (h secretservice) Add(creds *credentials.Credentials) error {
return nil
}
// Delete removes credentials from the keychain.
func (h secretservice) Delete(serverURL string) error {
// Delete removes credentials from the store.
func (h Secretservice) Delete(serverURL string) error {
if serverURL == "" {
return errors.New("missing server url")
}
@@ -58,7 +54,7 @@ func (h secretservice) Delete(serverURL string) error {
}
// Get returns the username and secret to use for a given registry server URL.
func (h secretservice) Get(serverURL string) (string, string, error) {
func (h Secretservice) Get(serverURL string) (string, string, error) {
if serverURL == "" {
return "", "", errors.New("missing server url")
}
+2 -2
View File
@@ -15,7 +15,7 @@ func TestSecretServiceHelper(t *testing.T) {
Secret: "foobarbaz",
}
helper := New()
helper := Secretservice{}
if err := helper.Add(creds); err != nil {
t.Fatal(err)
}
@@ -41,7 +41,7 @@ func TestSecretServiceHelper(t *testing.T) {
func TestMissingCredentials(t *testing.T) {
t.Skip("test requires gnome-keyring but travis CI doesn't have it")
helper := New()
helper := Secretservice{}
_, _, err := helper.Get("https://adsfasdf.wrewerwer.com/asdfsdddd")
if err != credentials.ErrCredentialsNotFound {
t.Fatalf("exptected ErrCredentialsNotFound, got %v", err)