notkshitij/docker-credential-helpers
1
0
Fork 0
mirror of https://github.com/docker/docker-credential-helpers.git synced 2026-06-13 16:01:28 +05:30
Code Releases 1 Activity

Merge pull request #367 from akerouanton/osxkeychain-set-atyp

Browse Source 
osxkeychain: store: add atyp attribute
This commit is contained in:
Albin Kerouanton
2025-03-14 12:52:36 +01:00
committed by GitHub
parent cfd6d21216 e7bd3957ae
commit f9d3010165
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osxkeychain/osxkeychain.go
+11
View File
@@ -46,6 +46,17 @@ func (h Osxkeychain) Add(creds *credentials.Credentials) error {
item.SetLabel(credentials.CredsLabel) item.SetLabel(credentials.CredsLabel)
item.SetAccount(creds.Username) item.SetAccount(creds.Username)
item.SetData([]byte(creds.Secret)) item.SetData([]byte(creds.Secret))
// Prior to v0.9, the credential helper was searching for credentials with
// the "dflt" authentication type (see [1]). Since v0.9.0, Get doesn't use
// that attribute anymore, and v0.9.0 - v0.9.2 were not setting it here
// either.
//
// In order to keep compatibility with older versions, we need to store
// credentials with this attribute set. This way, credentials stored with
// newer versions can be retrieved by older versions.
//
// [1]: https://github.com/docker/docker-credential-helpers/blob/v0.8.2/osxkeychain/osxkeychain.c#L66
item.SetAuthenticationType("dflt")
if err := splitServer(creds.ServerURL, item); err != nil { if err := splitServer(creds.ServerURL, item); err != nil {
return err return err
} }