87c80bfba5
Fix a double free in the List functions
...
The code was set up so that it would free the individual items and the data
in `freeListData`, but there was already a Go `defer` to free the data item,
resulting in a double free.
Remove the `free` in `freeListData` and leave the original one.
In addition, move the `defer` for freeing the list data before the error
check, so that the data is also free in the error case. This just removes
a minor leak.
This vulnerability was discovered by:
Jasiel Spelman of Trend Micro Zero Day Initiative and Trend Micro Team Nebula
Signed-off-by: Justin Cormack <justin.cormack@docker.com >
2019-07-01 14:41:30 +01:00
e522e56699
Fix memory leaks and non-null terminated strings usage
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2017-03-10 15:23:17 +01:00
8cb3338668
Filter docker credentials with label directly through libsecret
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2017-03-10 15:18:14 +01:00
cd76e4253f
Use the proper docker secret schema for items to search for
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2017-03-10 15:15:05 +01:00
021d7d6a19
Add label filter on the list of secrets
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2017-03-10 15:14:34 +01:00
f7f2744e6d
Add a Docker Credentials label support for linux
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2017-03-10 15:11:25 +01:00
d2e6ed779a
moved loop variable declaration to comply with c mode in travis
...
Signed-off-by: Avi Vaid <avaid1996@gmail.com >
2016-07-12 12:51:30 -04:00
7566a1e399
implemented freeing memory in secretservice and made minor edits to osxkeychain
...
Signed-off-by: Avi Vaid <avaid1996@gmail.com >
2016-07-11 19:45:37 -04:00
72661b3103
Implemented list functionality for secretservice- linux
...
Signed-off-by: Avi Vaid <avaid1996@gmail.com >
2016-07-11 19:33:35 -04:00
2275377a31
Move away from password as a name. We store secrets.
...
Signed-off-by: David Calavera <david.calavera@gmail.com >
2016-03-09 16:16:01 -05:00
a96948acb3
secretservice: add D-Bus secret service
...
Signed-off-by: Antonio Murdaca <runcom@redhat.com >
2016-03-07 15:03:35 +01:00
Justin Cormack