73e5f5dbfe
Merge pull request #29 from dekkagaijin/freefix
...
C.free(unsafe.Pointer(err)) -> C.g_error_free(err)
2018-07-19 09:47:51 +02:00
5241b46610
Merge pull request #110 from euank/lazy-init
...
pass: only init on run, and do so lazily
2018-06-27 14:33:29 +02:00
3cba3913ea
pass: add IsInitialized helper
...
This will be useful for the cli where they check initialization:
https://github.com/docker/cli/blob/be8dab26a3ab589b96788fdb95f3d07378e57b9b/cli/config/credentials/default_store_linux.go#L8-L10
Signed-off-by: Euan Kemp <euank@euank.com >
Signed-off-by: Vincent Demeester <vincent@sbr.pm >
2018-06-27 14:28:47 +02:00
8502b53592
Merge pull request #108 from euank/pass-trimtrim-pass
...
pass: trim pass show output
2018-06-27 14:24:08 +02:00
5da09fd251
pass: only init on run, and do so lazily
...
This also fixes the following issues:
1. Safe for concurrent initialization still (it was before in 'init',
but the alternative to this PR is not)
2. Uses the same password directory during init as it does during
runtime (the change to getPassDir in initialization logic.
3. Prints significantly better errors if initialization fails
4. Has slightly cleaner abstractions by hiding the initialization check
in 'runPass'
The 4th item there does mean there are a few cases where more work is
done before erroring, but that amount of work is trivial and my manual
audit didn't reveal anything that seemed worrying.
Fixes #96 , alternative to #106
Signed-off-by: Euan Kemp <euank@euank.com >
2018-06-27 14:23:22 +02:00
dd27c246bd
pass: trim pass show output
...
As of 8446a40, pass show will include a newline when showing a password.
This causes the pass helper here to reliably fail to initialize since a
password doesn't round-trip.
Before making this change, the pass test would fail if the installed
password-store version was v1.7.1+, and after this change it passes
again.
Fixes #107
Signed-off-by: Euan Kemp <euank@euank.com >
2018-06-27 14:21:52 +02:00
26deb2937d
Merge pull request #109 from euank/better-exec
...
pass: simplify some code
2018-06-27 14:19:27 +02:00
a13ff50017
pass: simplify some code
...
The exec.Command code and os.Getenv implementation were both needlessly
verbose. This replaces them with simpler variations.
Signed-off-by: Euan Kemp <euank@euank.com >
2018-06-27 14:15:36 +02:00
1c295f7de8
Merge pull request #115 from n4ss/fix-appveyor
...
Fix Windows CI
2018-06-27 14:14:13 +02:00
093af814ee
fix go vet complaining on composite literales
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-27 14:02:28 +02:00
d499cf5cb9
Merge pull request #114 from n4ss/fix-travisci-osxkeychain
...
fix osxkeychain ci
2018-06-27 13:52:26 +02:00
b049338a6b
Fix appveyor windows ci
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-27 13:45:32 +02:00
91fc39d57a
install yarn on osx for travisci
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-27 13:22:53 +02:00
317219f3a6
Fix yarn complaint in travisci
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-27 12:13:18 +02:00
21f4937ebc
fix osxkeychain ci
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-27 11:58:22 +02:00
19b711cc92
Merge pull request #100 from vdemeester/update-maintainers
...
Update MAINTAINERS file with current maintainers
2018-02-14 08:13:21 +01:00
1f635a73ad
Update MAINTAINERS file with current maintainers
...
Signed-off-by: Vincent Demeester <vincent@sbr.pm >
2018-02-12 14:39:43 +01:00
302e4ae938
Typo fixed.
...
Signed-off-by: Piano Kang <kang@bridgewell.com >
2017-12-20 13:37:43 +08:00
d68f9aeca3
Merge pull request #88 from n4ss/add-pass-config-notice
...
Add instructions for pass helper configuration
2017-08-30 14:17:07 +02:00
05a9d4c50d
Merge pull request #89 from tych0/better-initialization-check
...
pass: better initialization check
2017-08-29 21:46:31 +02:00
c2eec534ee
pass: better initialization check
...
See comment for details, but basically, let's actually use pass to check
that it works.
Signed-off-by: Tycho Andersen <tycho@docker.com >
2017-08-29 08:25:08 -07:00
5be80ca212
Add instructions for pass helper configuration
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2017-08-28 18:11:27 +02:00
f00de1b72f
Merge pull request #87 from n4ss/bump-0.6.0
...
Bump 0.6.0
2017-08-28 14:18:12 +02:00
72f0375e37
Bump 0.6.0
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2017-08-25 19:37:31 +02:00
3cce61446f
Merge pull request #85 from promiseofcake/ljk-fix-makefile
...
Fix Makefile issues
2017-08-25 18:50:05 +02:00
ec0d036273
Fix Makefile issues
...
* mkdir fails when `bin` exists
* obtaining golint fails if previously installed (w/out the -u flag)
Signed-off-by: Lucas Kacher <lucas@vsco.co >
2017-08-23 11:08:54 -04:00
d3d9934897
Merge pull request #84 from tych0/fix-helpers-protocol
...
return "" instead of an error when pass isn't present
2017-08-22 20:10:46 +02:00
f212ea17df
fix test
...
Signed-off-by: Tycho Andersen <tycho@docker.com >
2017-08-17 10:36:48 -06:00
09e536a128
return "" instead of an error when pass isn't present
...
It turns out the cred helpers protocol is to return "" and not an error
when a credential isn't present, so let's do that.
Signed-off-by: Tycho Andersen <tycho@docker.com >
2017-08-17 09:19:19 -06:00
3c90bd29a4
Merge pull request #83 from tych0/expose-pass-initialized
...
pass backend: expose pass initialized flag
2017-08-16 11:06:21 +02:00
b8fb9690c8
pass backend: expose pass initialized flag
...
This way clients don't have to run their own checks, they can just use the
library's detection.
Signed-off-by: Tycho Andersen <tycho@docker.com >
2017-08-14 08:56:59 -06:00
7efaffb4c4
Merge pull request #81 from tych0/pass-backend-and-package
...
Add `pass` backend and debian packaging for both -secretservice and -pass backends
2017-08-14 16:00:25 +02:00
6338c06ba4
Merge pull request #69 from shhsu/command_env
...
A new entry point for calling the cred helpers that allow passing environment variables
2017-08-14 11:15:13 +02:00
86c94d3e30
add a deb package for pass/secret service backends
...
Note that this single source package produces two binary packages: one for
-pass, and one for -secretservice, so that users can install whichever
password backend (and thus deps) that they want.
Signed-off-by: Tycho Andersen <tycho@docker.com >
2017-08-11 08:15:29 -06:00
1ab1037707
add a pass credential helper backend
...
Signed-off-by: Tycho Andersen <tycho@docker.com >
2017-08-11 08:15:29 -06:00
c69c0725bb
A new entry point for calling the cred helpers that allow passing environment variables
...
Signed-off-by: Peter Hsu <shhsu@microsoft.com >
2017-06-30 10:45:22 -07:00
a8de4f6e8a
Merge pull request #77 from jeanlaurent/win-release
...
Adding winrelease target
2017-06-15 12:39:03 +02:00
4fbc86d7d0
Adding winrelease target
...
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net >
2017-06-15 12:03:00 +02:00
2d19ebb7f4
Merge pull request #76 from thaJeztah/bump-0.5.2
...
Bump version 0.5.2
2017-06-15 11:31:05 +02:00
054c53824f
Bump version 0.5.2
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2017-06-15 11:21:41 +02:00
be1808e3ed
Merge pull request #75 from thaJeztah/update-changelog
...
Update changelog
2017-06-15 11:07:09 +02:00
e1d4c012bc
Fix storing URLs without scheme ( #72 )
...
* Fix storing URLs without scheme
If secrets are stored without specifying a scheme
(https://), the keychain-helper would interpret the
hostname as _path_, causing lookup of secrets to fail.
This patch makes sure that a scheme is added (if missing).
If no scheme is specified, https:// is used as a default.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
* Have pre go1.8 compiler able to compile
Signed-off-by: Tibor Vass <teabee89@gmail.com >
* Fix URL parsing with port and no scheme
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
* Improve parseURL comment
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2017-06-15 10:58:17 +02:00
ad6ee5d58d
Update changelog
...
The changelog wasn't updated for each release.
This patch updates the changelog, with changes
taken from the releases page
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2017-06-15 00:46:21 +02:00
94be56b6f4
Merge pull request #74 from thaJeztah/bump-travis-to-go-18
...
Update TravisCI to use Go 1.8
2017-06-14 22:08:13 +02:00
37bf8afe8b
Update TravisCI to use Go 1.8
...
To match the version used in docker
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2017-06-14 21:29:13 +02:00
3d7e1817f2
Merge pull request #73 from n4ss/travisci-golang1.7
...
Update TravisCI to use Go 1.7
2017-06-14 17:21:44 +02:00
5651367281
Update TravisCI to use Go 1.7
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2017-06-14 16:18:01 +02:00
d8f57a18c6
Merge pull request #61 from danieljoos/linux32
...
Workaround for Linux 32-bit build
2017-05-30 20:56:52 +02:00
4bc0bc2a85
Merge pull request #67 from jeanlaurent/add-version-command
...
Add version command
2017-05-30 19:13:34 +02:00
167b137eb4
vet/lint/fmt before release
...
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net >
2017-05-30 18:26:18 +02:00
Vincent Demeester