69fb197018
Don’t use binaries built by Travis. Use Jenkins binaries.
...
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com >
2019-07-17 10:35:02 +02:00
86b653a9f1
Create tarballs in Jenkins.
...
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com >
2019-07-17 10:34:50 +02:00
88f932172b
Remove old appveyor configuration
...
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com >
2019-07-17 10:12:27 +02:00
54f0238b6b
Merge pull request #157 from guillaumerose/bump
...
Bump to 0.6.3
2019-07-16 13:54:57 +02:00
2bf42cfd47
Bump to 0.6.3
...
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com >
2019-07-16 10:46:07 +02:00
1c9f7ede70
Merge pull request from GHSA-g9w7-h2f5-5vp2
...
Fix a double free in the List functions
2019-07-16 09:57:38 +02:00
87c80bfba5
Fix a double free in the List functions
...
The code was set up so that it would free the individual items and the data
in `freeListData`, but there was already a Go `defer` to free the data item,
resulting in a double free.
Remove the `free` in `freeListData` and leave the original one.
In addition, move the `defer` for freeing the list data before the error
check, so that the data is also free in the error case. This just removes
a minor leak.
This vulnerability was discovered by:
Jasiel Spelman of Trend Micro Zero Day Initiative and Trend Micro Team Nebula
Signed-off-by: Justin Cormack <justin.cormack@docker.com >
2019-07-01 14:41:30 +01:00
680ca48e6d
Merge pull request #153 from thaJeztah/merge_0.6.2
...
Merge 'v0.6.2' to master
2019-06-20 14:53:21 +02:00
f6d4261609
Merge 'v0.6.2' to master
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2019-06-20 11:51:07 +02:00
f755519945
Merge pull request #148 from guillaumerose/jenkinsfile
...
Add Jenkinsfile
2019-05-07 08:12:18 -07:00
11d9f9dba7
Add Jenkinsfile
...
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com >
2019-05-07 16:04:36 +02:00
beda055c57
Merge pull request #145 from ulrich/bump-to-v0.6.2
...
Bump version to 0.6.2
2019-05-02 12:50:58 +02:00
22b8706efa
Bump version to 0.6.2
...
Signed-off-by: Ulrich VACHON <ulrich.vachon@docker.com >
2019-05-02 12:41:03 +02:00
8a9f93a99f
Bump version to 0.6.2
...
Signed-off-by: Ulrich VACHON <ulrich.vachon@docker.com >
2019-05-02 12:10:16 +02:00
063cca0a6d
Merge pull request #97 from s864372002/hotfix/typo
...
Typo fixed.
2019-04-30 00:43:22 -07:00
152d64310b
Merge pull request #139 from ekcasey/server-alias-wincred
...
make docker-credential-wincred work like docker-credential-osxkeychain
2019-04-30 09:10:39 +02:00
77e30bd9dd
Style fixes - incorporates PR feedback
...
Signed-off-by: Emily Casey <ecasey@pivotal.io >
Signed-off-by: Danny Joyce <djoyce@pivotal.io >
2019-04-29 10:51:04 -04:00
74636a1592
Merge pull request #143 from pgayvallet/osx-list-no-error-on-missing-key
...
Fix docker-credential-osxkeychain list behaviour in case of missing entry in keychain
2019-04-29 16:27:28 +02:00
a3c1b5b757
Fix imports
...
Signed-off-by: Emily Casey <ecasey@pivotal.io >
2019-04-29 10:04:46 -04:00
6f4b0a7c06
make docker-credential-wincred work like docker-credential-osxkeychain
...
* fetch credentials for server with matching hostname if scheme, path, or port are not provided
* if the credential request includes specific scheme, path, or port that does not match entry, don't return
* extract url helpers into a package
Signed-off-by: Emily Casey <ecasey@pivotal.io >
Signed-off-by: Danny Joyce <djoyce@pivotal.io >
2019-04-29 09:26:13 -04:00
1546024a83
returns empty map instead of error if credentials not found in keychain
...
Signed-off-by: pgayvallet <pierre.gayvallet@gmail.com >
2019-04-26 18:34:58 +02:00
ecb01138bd
Merge pull request #142 from ulrich/fix_travis_ci
...
Fix Travis configuration, update XCode version, Golang version and set to minimum macOS version to 10.11.
2019-04-26 09:27:06 -07:00
df92c83808
Update Go version to 1.12.x, update XCode version to 10.1, update MacOS minimum supported version to 10.11.
...
Signed-off-by: Ulrich VACHON <ulrich.vachon@docker.com >
2019-04-26 12:00:35 +02:00
123ba1b7cd
Merge pull request #124 from eyJhb/master
...
pass: changed the way for checking if password-store is initalized
2018-09-25 10:51:22 +02:00
9c18f033f7
pass: changed error message returned, if password-store is not initialized
...
Signed-off-by: eyjhbb@gmail.com <eyjhbb@gmail.com >
2018-09-24 15:15:24 +02:00
d6c1f136e4
pass: changed the way for checking if password-store is initalized
...
Signed-off-by: eyjhbb@gmail.com <eyjhbb@gmail.com >
2018-09-22 12:53:56 +02:00
73e5f5dbfe
Merge pull request #29 from dekkagaijin/freefix
...
C.free(unsafe.Pointer(err)) -> C.g_error_free(err)
2018-07-19 09:47:51 +02:00
5241b46610
Merge pull request #110 from euank/lazy-init
...
pass: only init on run, and do so lazily
2018-06-27 14:33:29 +02:00
3cba3913ea
pass: add IsInitialized helper
...
This will be useful for the cli where they check initialization:
https://github.com/docker/cli/blob/be8dab26a3ab589b96788fdb95f3d07378e57b9b/cli/config/credentials/default_store_linux.go#L8-L10
Signed-off-by: Euan Kemp <euank@euank.com >
Signed-off-by: Vincent Demeester <vincent@sbr.pm >
2018-06-27 14:28:47 +02:00
8502b53592
Merge pull request #108 from euank/pass-trimtrim-pass
...
pass: trim pass show output
2018-06-27 14:24:08 +02:00
5da09fd251
pass: only init on run, and do so lazily
...
This also fixes the following issues:
1. Safe for concurrent initialization still (it was before in 'init',
but the alternative to this PR is not)
2. Uses the same password directory during init as it does during
runtime (the change to getPassDir in initialization logic.
3. Prints significantly better errors if initialization fails
4. Has slightly cleaner abstractions by hiding the initialization check
in 'runPass'
The 4th item there does mean there are a few cases where more work is
done before erroring, but that amount of work is trivial and my manual
audit didn't reveal anything that seemed worrying.
Fixes #96 , alternative to #106
Signed-off-by: Euan Kemp <euank@euank.com >
2018-06-27 14:23:22 +02:00
dd27c246bd
pass: trim pass show output
...
As of 8446a40, pass show will include a newline when showing a password.
This causes the pass helper here to reliably fail to initialize since a
password doesn't round-trip.
Before making this change, the pass test would fail if the installed
password-store version was v1.7.1+, and after this change it passes
again.
Fixes #107
Signed-off-by: Euan Kemp <euank@euank.com >
2018-06-27 14:21:52 +02:00
26deb2937d
Merge pull request #109 from euank/better-exec
...
pass: simplify some code
2018-06-27 14:19:27 +02:00
a13ff50017
pass: simplify some code
...
The exec.Command code and os.Getenv implementation were both needlessly
verbose. This replaces them with simpler variations.
Signed-off-by: Euan Kemp <euank@euank.com >
2018-06-27 14:15:36 +02:00
1c295f7de8
Merge pull request #115 from n4ss/fix-appveyor
...
Fix Windows CI
2018-06-27 14:14:13 +02:00
093af814ee
fix go vet complaining on composite literales
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-27 14:02:28 +02:00
d499cf5cb9
Merge pull request #114 from n4ss/fix-travisci-osxkeychain
...
fix osxkeychain ci
2018-06-27 13:52:26 +02:00
b049338a6b
Fix appveyor windows ci
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-27 13:45:32 +02:00
91fc39d57a
install yarn on osx for travisci
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-27 13:22:53 +02:00
317219f3a6
Fix yarn complaint in travisci
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-27 12:13:18 +02:00
21f4937ebc
fix osxkeychain ci
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2018-06-27 11:58:22 +02:00
19b711cc92
Merge pull request #100 from vdemeester/update-maintainers
...
Update MAINTAINERS file with current maintainers
2018-02-14 08:13:21 +01:00
1f635a73ad
Update MAINTAINERS file with current maintainers
...
Signed-off-by: Vincent Demeester <vincent@sbr.pm >
2018-02-12 14:39:43 +01:00
302e4ae938
Typo fixed.
...
Signed-off-by: Piano Kang <kang@bridgewell.com >
2017-12-20 13:37:43 +08:00
d68f9aeca3
Merge pull request #88 from n4ss/add-pass-config-notice
...
Add instructions for pass helper configuration
2017-08-30 14:17:07 +02:00
05a9d4c50d
Merge pull request #89 from tych0/better-initialization-check
...
pass: better initialization check
2017-08-29 21:46:31 +02:00
c2eec534ee
pass: better initialization check
...
See comment for details, but basically, let's actually use pass to check
that it works.
Signed-off-by: Tycho Andersen <tycho@docker.com >
2017-08-29 08:25:08 -07:00
5be80ca212
Add instructions for pass helper configuration
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2017-08-28 18:11:27 +02:00
f00de1b72f
Merge pull request #87 from n4ss/bump-0.6.0
...
Bump 0.6.0
2017-08-28 14:18:12 +02:00
72f0375e37
Bump 0.6.0
...
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com >
2017-08-25 19:37:31 +02:00
Guillaume Rose