notkshitij/docker-credential-helpers
1
0
Fork 0
mirror of https://github.com/docker/docker-credential-helpers.git synced 2026-06-13 16:01:28 +05:30
Code Releases 1 Activity
346 Commits 2 Branches 30 Tags
c1c7dd70113e81e7e4e648556760a28cf1439353
Commit Graph

11 Commits

Author SHA1 Message Date
Sebastiaan van Stijn c1c7dd7011 credentials: fix minor nits in tests 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-30 11:02:44 +02:00
Sebastiaan van Stijn 14d46ffd7e credentials: don't fail tests early, and use consts 
- use consts for fixed values in tests
- don't fail tests early if there's more we can test

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-27 17:14:13 +02:00
Sebastiaan van Stijn 9817a23b17 format code with gofumpt 
Doing a one-pass of formatting the code with gofumpt, which provides a
superset of gofmt.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-27 13:01:49 +02:00
Sebastiaan van Stijn e1d4c012bc Fix storing URLs without scheme (#72) 
* Fix storing URLs without scheme

If secrets are stored without specifying a scheme
(https://), the keychain-helper would interpret the
hostname as _path_, causing lookup of secrets to fail.

This patch makes sure that a scheme is added (if missing).

If no scheme is specified, https:// is used as a default.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* Have pre go1.8 compiler able to compile

Signed-off-by: Tibor Vass <teabee89@gmail.com>

* Fix URL parsing with port and no scheme

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>

* Improve parseURL comment

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2017-06-15 10:58:17 +02:00
Nassim Eddequiouaq ed11c58ebf Prevent invalid credentials: no missing server URL or username (#62) 
* Prevent invalid credentials: no missing server URL or username

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>

* Add missing username/serverURL error checks in credstore client

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>

* Clean up doc on invalid creds errors and client's error checks

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>

* Add tests for missing ServerURL/Username

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>

* Clean isValidCredsMessage prototype

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>

* Add test for missing server URL and more detailed error msg

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2017-05-29 10:21:50 +02:00
Jake Sanders c45d9e9e28 Implement client.List, change list API 
[]string, []string -> map[string]string because the other APIs assume a
1:1 correspondence

Signed-off-by: Jake Sanders <jsand@google.com>
 2016-09-02 15:15:12 -07:00
avaid96 205e3b3056 cleaned up some of the osx code, added a better test for list 
Signed-off-by: avaid96 <avaid1996@gmail.com>
 2016-07-11 23:34:20 -07:00
avaid96 5a8fb214ed Full implementation for OSX ready 
Signed-off-by: avaid96 <avaid1996@gmail.com>
 2016-07-11 10:50:44 -07:00
David Calavera 039c315f22 Export credentials functions to be able to use them as a library. 
Signed-off-by: David Calavera <david.calavera@gmail.com>
 2016-03-24 14:52:17 -04:00
David Calavera 2275377a31 Move away from password as a name. We store secrets. 
Signed-off-by: David Calavera <david.calavera@gmail.com>
 2016-03-09 16:16:01 -05:00
David Calavera a701e3c310 Remove extra package. 
Signed-off-by: David Calavera <david.calavera@gmail.com>
 2016-02-09 13:03:40 -08:00