notkshitij/docker-credential-helpers
1
0
Fork 0
mirror of https://github.com/docker/docker-credential-helpers.git synced 2026-06-13 16:01:28 +05:30
Code Releases 1 Activity
362 Commits 2 Branches 30 Tags
v0.8.0
Commit Graph

41 Commits

Author SHA1 Message Date
Sebastiaan van Stijn 13475b4387 credentials: use designated domains in tests (RFC2606) 
Update domains used in tests to used domains that are designated for this
purpose as described in [RFC2606, section 3][1]

[1]: https://www.rfc-editor.org/rfc/rfc2606.html#section-3

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-06-26 13:59:01 +02:00
Sebastiaan van Stijn a228f55121 credentials: implement errdefs types for typed errors 
This allows for checking the error-type returned to be matched with
the errdefs utilities.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-06-15 14:59:44 +02:00
Sebastiaan van Stijn dbfb389f83 credentials: use errors.As() to match error-types 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-06-15 14:59:35 +02:00
Sebastiaan van Stijn c1c7dd7011 credentials: fix minor nits in tests 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-30 11:02:44 +02:00
Sebastiaan van Stijn 129017a3cd credentials: define consts for supported actions (sub-commands) 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-28 13:53:34 +02:00
Sebastiaan van Stijn 99079cafd2 credentials: Serve(): implement "--version, -v", and "--help, -h" flags 
As recommended in the GNU documentation;

- https://www.gnu.org/prep/standards/standards.html#g_t_002d_002dversion
- https://www.gnu.org/prep/standards/standards.html#g_t_002d_002dhelp

With this patch:

    $ docker-credential-osxkeychain --version
    docker-credential-osxkeychain (github.com/docker/docker-credential-helpers) v0.7.0-51-g26c426e.m

    $ docker-credential-osxkeychain -v
    docker-credential-osxkeychain (github.com/docker/docker-credential-helpers) v0.7.0-51-g26c426e.m

    $ docker-credential-osxkeychain --help
    Usage: docker-credential-osxkeychain <store|get|erase|list|version>

    $ docker-credential-osxkeychain -h
    Usage: docker-credential-osxkeychain <store|get|erase|list|version>

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-28 13:53:34 +02:00
Sebastiaan van Stijn ae1d1ec013 credentials: HandleCommand(): improve error for unknown command/action 
- renamed the "key" variable, which was slightly confusing
- include the name of the binary in the error

Before this change:

    docker-credential-osxkeychain nosuchaction
    Unknown credential action `nosuchaction`

After this change:

    docker-credential-osxkeychain nosuchaction
    docker-credential-osxkeychain: unknown action: nosuchaction

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-28 13:53:34 +02:00
Sebastiaan van Stijn db0ac44c97 credentials: Serve(): simplify error-handling logic 
Don't use an err if we can print the error immediately :)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-28 13:53:34 +02:00
Sebastiaan van Stijn 0dbcdb66a7 credentials: Serve(): use "Name instead of "os.Args[0]" for usage output 
GNU guidelines describes; https://www.gnu.org/prep/standards/html_node/_002d_002dversion.html#g_t_002d_002dversion

    The program’s name should be a constant string; don’t compute it from argv[0].
    The idea is to state the standard or canonical name for the program, not its
    file name.

Although the above recommendation is for `--version` output, it probably makes
sense to do the same for the "usage" output.

Before this change:

    /usr/local/bin/docker-credential-osxkeychain invalid command
    Usage: /usr/local/bin/docker-credential-osxkeychain <store|get|erase|list|version>

    /Applications/Docker.app/Contents/Resources/bin/docker-credential-osxkeychain invalid command
    Usage: /Applications/Docker.app/Contents/Resources/bin/docker-credential-osxkeychain <store|get|erase|list|version>

With this patch:

    /usr/local/bin/docker-credential-osxkeychain invalid command
    Usage: docker-credential-osxkeychain <store|get|erase|list|version>

    /Applications/Docker.app/Contents/Resources/bin/docker-credential-osxkeychain invalid command
    Usage: docker-credential-osxkeychain <store|get|erase|list|version>

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-28 13:53:23 +02:00
Sebastiaan van Stijn c324fe0a6f credentials: Get(): remove intermediate variable 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-28 12:38:05 +02:00
Sebastiaan van Stijn 19557f8fff fix some errCheck warnings, and update examples 
- Explicitly suppress some unhandled errors
- Use "pass" credentials helper in examples, which is available
  on more platforms than "secretservice" (only supporte on Linux)
- Update domain and username in examples.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-28 12:33:58 +02:00
Sebastiaan van Stijn 94483d2d23 godoc: credentials helper -> credentials-helper 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-28 12:13:49 +02:00
Sebastiaan van Stijn 14d46ffd7e credentials: don't fail tests early, and use consts 
- use consts for fixed values in tests
- don't fail tests early if there's more we can test

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-27 17:14:13 +02:00
Sebastiaan van Stijn 9817a23b17 format code with gofumpt 
Doing a one-pass of formatting the code with gofumpt, which provides a
superset of gofmt.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-05-27 13:01:49 +02:00
CrazyMax a37d38a864 Set version and revision at linked time 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
 2022-08-25 14:50:18 +02:00
Sebastiaan van Stijn fd0197473f update to go 1.18.5 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2022-08-20 20:49:39 +02:00
ebriney 0232333efa Bump to 0.6.4 
Signed-off-by: ebriney <emmanuel.briney@docker.com>
 2021-05-27 17:11:30 +02:00
Guillaume Rose 2bf42cfd47 Bump to 0.6.3 
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com>
 2019-07-16 10:46:07 +02:00
Ulrich VACHON 22b8706efa Bump version to 0.6.2 
Signed-off-by: Ulrich VACHON <ulrich.vachon@docker.com>
 2019-05-02 12:41:03 +02:00
Ulrich VACHON df92c83808 Update Go version to 1.12.x, update XCode version to 10.1, update MacOS minimum supported version to 10.11. 
Signed-off-by: Ulrich VACHON <ulrich.vachon@docker.com>
 2019-04-26 12:00:35 +02:00
Nassim 'Nass' Eddequiouaq 72f0375e37 Bump 0.6.0 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2017-08-25 19:37:31 +02:00
Sebastiaan van Stijn 054c53824f Bump version 0.5.2 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2017-06-15 11:21:41 +02:00
Sebastiaan van Stijn e1d4c012bc Fix storing URLs without scheme (#72) 
* Fix storing URLs without scheme

If secrets are stored without specifying a scheme
(https://), the keychain-helper would interpret the
hostname as _path_, causing lookup of secrets to fail.

This patch makes sure that a scheme is added (if missing).

If no scheme is specified, https:// is used as a default.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* Have pre go1.8 compiler able to compile

Signed-off-by: Tibor Vass <teabee89@gmail.com>

* Fix URL parsing with port and no scheme

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>

* Improve parseURL comment

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2017-06-15 10:58:17 +02:00
Jean-Laurent de Morlhon 2a67ef1524 make linter happy 
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
 2017-05-30 18:26:18 +02:00
Jean-Laurent de Morlhon fa4a4d4f71 Bump Version 0.5.1-> 0.5.2-devel 
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
 2017-05-30 18:26:18 +02:00
Jean-Laurent de Morlhon 4d60b372aa Add a version command 
Signed-off-by: Jean-Laurent de Morlhon <jeanlaurent@morlhon.net>
 2017-05-30 18:26:18 +02:00
Nassim Eddequiouaq ed11c58ebf Prevent invalid credentials: no missing server URL or username (#62) 
* Prevent invalid credentials: no missing server URL or username

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>

* Add missing username/serverURL error checks in credstore client

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>

* Clean up doc on invalid creds errors and client's error checks

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>

* Add tests for missing ServerURL/Username

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>

* Clean isValidCredsMessage prototype

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>

* Add test for missing server URL and more detailed error msg

Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2017-05-29 10:21:50 +02:00
Nassim 'Nass' Eddequiouaq 7133af577e Creds label can be configured from helpers 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2017-03-11 12:34:22 +01:00
Nassim 'Nass' Eddequiouaq 2a8670e0da Cleanup original modifications to the exposed APIs 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2017-03-10 15:14:04 +01:00
Nassim 'Nass' Eddequiouaq cfe7556d6d [SYNTAX] Run gofmt on changed files 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2017-03-10 15:12:12 +01:00
Nassim 'Nass' Eddequiouaq 595b7f2531 Add a Docker Credentials label to store and list creds 
Signed-off-by: Nassim 'Nass' Eddequiouaq <eddequiouaq.nassim@gmail.com>
 2017-03-10 15:10:54 +01:00
Jake Sanders c45d9e9e28 Implement client.List, change list API 
[]string, []string -> map[string]string because the other APIs assume a
1:1 correspondence

Signed-off-by: Jake Sanders <jsand@google.com>
 2016-09-02 15:15:12 -07:00
avaid96 8fa18eb16c implementation on client side as well, complete with tests 
Signed-off-by: avaid96 <avaid1996@gmail.com>
 2016-07-13 10:20:51 -07:00
avaid96 205e3b3056 cleaned up some of the osx code, added a better test for list 
Signed-off-by: avaid96 <avaid1996@gmail.com>
 2016-07-11 23:34:20 -07:00
avaid96 5a8fb214ed Full implementation for OSX ready 
Signed-off-by: avaid96 <avaid1996@gmail.com>
 2016-07-11 10:50:44 -07:00
David Calavera c4fc9c07dd Add client functions to allow integrations within other CLIs. 
This is a simplification of how the docker engine implements
this feature, but it will be ported there once this is merged.

Signed-off-by: David Calavera <david.calavera@gmail.com>
 2016-05-30 12:32:26 -07:00
David Calavera 039c315f22 Export credentials functions to be able to use them as a library. 
Signed-off-by: David Calavera <david.calavera@gmail.com>
 2016-03-24 14:52:17 -04:00
David Calavera 2275377a31 Move away from password as a name. We store secrets. 
Signed-off-by: David Calavera <david.calavera@gmail.com>
 2016-03-09 16:16:01 -05:00
David Calavera a701e3c310 Remove extra package. 
Signed-off-by: David Calavera <david.calavera@gmail.com>
 2016-02-09 13:03:40 -08:00
David Calavera f4a0e81b0b Implement credential programs reading from Stdin. 
Signed-off-by: David Calavera <david.calavera@gmail.com>
 2016-02-09 10:53:34 -08:00
David Calavera b7ffbdb74f 🌅 complete OS X keychain implementation. 
Signed-off-by: David Calavera <david.calavera@gmail.com>
 2016-02-07 18:20:36 -08:00