Merge pull request #404 from thaJeztah/rm_noninteractive

Dockerfile: remove redundant DEBIAN_FRONTEND=noninteractive
2026-06-28 23:32:02 +05:30 · 2026-01-08 17:44:32 +01:00 · 2026-01-08 13:06:40 +01:00 · 2026-01-08 13:06:09 +01:00 · 2026-01-08 12:40:22 +01:00 · 2026-01-08 11:59:16 +01:00
3 changed files with 4 additions and 11 deletions
@@ -15,7 +15,7 @@ on:

 env:
  DESTDIR: ./bin
-  GO_VERSION: 1.25.2
+  GO_VERSION: 1.25.5

 jobs:
  validate:
@@ -1,12 +1,11 @@
 # syntax=docker/dockerfile:1

-ARG GO_VERSION=1.25.2
+ARG GO_VERSION=1.25.5
 ARG DEBIAN_VERSION=bookworm

 ARG XX_VERSION=1.7.0
 ARG OSXCROSS_VERSION=11.3-r8-debian
-ARG GOLANGCI_LINT_VERSION=v2.5
-ARG DEBIAN_FRONTEND=noninteractive
+ARG GOLANGCI_LINT_VERSION=v2.8

 ARG PACKAGE=github.com/docker/docker-credential-helpers

@@ -18,7 +17,6 @@ FROM crazymax/osxcross:${OSXCROSS_VERSION} AS osxcross

 FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-${DEBIAN_VERSION} AS gobase
 COPY --from=xx / /
-ARG DEBIAN_FRONTEND
 RUN apt-get update && apt-get install -y --no-install-recommends clang dpkg-dev file git lld llvm make pkg-config rsync
 ENV GOFLAGS="-mod=vendor"
 ENV CGO_ENABLED="1"
@@ -56,7 +54,6 @@ EOT

 FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION} AS golangci-lint
 FROM gobase AS lint
-ARG DEBIAN_FRONTEND
 RUN apt-get install -y binutils gcc libc6-dev libgcc-11-dev libsecret-1-dev pkg-config
 RUN --mount=type=bind,target=. \
    --mount=type=cache,target=/root/.cache \
@@ -65,11 +62,9 @@ RUN --mount=type=bind,target=. \

 FROM gobase AS base
 ARG TARGETPLATFORM
-ARG DEBIAN_FRONTEND
 RUN xx-apt-get install -y binutils gcc libc6-dev libgcc-11-dev libsecret-1-dev pkg-config

 FROM base AS test
-ARG DEBIAN_FRONTEND
 RUN xx-apt-get install -y dbus-x11 gnome-keyring gpg-agent gpgconf libsecret-1-dev pass
 RUN --mount=type=bind,target=. \
    --mount=type=cache,target=/root/.cache \
@@ -1,14 +1,12 @@
 # syntax=docker/dockerfile:1

-ARG GO_VERSION=1.25.2
+ARG GO_VERSION=1.25.5
 ARG DISTRO=ubuntu
 ARG SUITE=jammy

 FROM golang:${GO_VERSION}-bookworm AS golang

 FROM ${DISTRO}:${SUITE}
-
-ARG DEBIAN_FRONTEND=noninteractive
 RUN apt-get update && apt-get install -yy debhelper dh-make libsecret-1-dev
 RUN mkdir -p /build
Author	SHA1	Message	Date
Sebastiaan van Stijn	b871f76540	Merge pull request #404 from thaJeztah/rm_noninteractive Dockerfile: remove redundant DEBIAN_FRONTEND=noninteractive	2026-01-08 17:44:32 +01:00
Sebastiaan van Stijn	50c1460bf5	Dockerfile: remove redundant DEBIAN_FRONTEND=noninteractive This should no longer be needed for current versions of Debian and Ubuntu. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2026-01-08 13:06:40 +01:00
Sebastiaan van Stijn	aecf6e5780	Merge pull request #402 from thaJeztah/bump_golangci_lint Dockerfile: update golangci-lint to v2.8	2026-01-08 13:06:09 +01:00
Sebastiaan van Stijn	ecf6c1ccc7	Merge pull request #399 from ameya-keskar/bump_go_1.25.5 update to go1.25.5	2026-01-08 12:40:22 +01:00
Ameya Keskar	b844409a12	update to go1.25.5 - Update Go version to v1.25.5 in build workflow - Update GO_VERSION to 1.25.5 in Dockerfile - Update GO_VERSION to 1.25.5 Signed-off-by: Ameya Keskar <55844298+ameya-keskar@users.noreply.github.com>	2026-01-08 11:59:16 +01:00
Sebastiaan van Stijn	7a15b77bcb	Dockerfile: update golangci-lint to v2.8 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>	2026-01-08 11:55:17 +01:00