Sebastiaan van Stijn 4c9fc240ed client: use os/exec/Cmd.Environ() instead of os.Environ() ...

Don't set Env if not set; the default is already handled if it's nil; from
the documentation: https://pkg.go.dev/os/exec@go1.20.4#Cmd.Env

    // If Env is nil, the new process uses the current process's
    // environment.

Use `os/exec/Cmd.Environ()` instead of `os.Environ()`, which was added in
go1.19, and handles additional environment variables, such as `PWD` on POSIX
systems, and `SYSTEMROOT` on Windows. https://pkg.go.dev/os/exec@go1.20.4#Cmd.Environ

Also remove a redundant `fmt.Sprintf()`, as we're only concatenating strings.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

2023-05-28 12:11:06 +02:00

..

client_test.go

client: don't use un-keyed literals in tests, and don't fail early

2023-05-27 17:14:13 +02:00

client.go

Prevent invalid credentials: no missing server URL or username (#62)

2017-05-29 10:21:50 +02:00

command.go

client: use os/exec/Cmd.Environ() instead of os.Environ()

2023-05-28 12:11:06 +02:00