CrazyMax
7346714456
ci: update bake-action to v6
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2025-01-10 10:53:21 +01:00
Sebastiaan van Stijn
7e7c5576ba
Merge pull request #342 from thaJeztah/less_indirection
...
client: remove some indirection and touch-up GoDoc
2024-10-28 10:43:29 +01:00
Sebastiaan van Stijn
ad253f54a5
client: remove some indirection and touch-up GoDoc
...
Both NewShellProgramFunc and NewShellProgramFuncWithEnv were using
createProgramCmdRedirectErr under the hood, but NewShellProgramFunc
had an extra indirection through NewShellProgramFuncWithEnv.
Make both a direct wrapper for createProgramCmdRedirectErr instead.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-10-25 14:41:30 +02:00
Sebastiaan van Stijn
fa991bcbeb
Merge pull request #338 from thaJeztah/bump_golangci_lint
...
Dockerfile: update golangci-lint to v1.61.0
2024-10-25 14:22:44 +02:00
Sebastiaan van Stijn
db1da9da5d
Merge pull request #339 from thaJeztah/bump_xx
...
Dockerfile: bump xx to v1.5.0
2024-10-25 13:54:32 +02:00
Sebastiaan van Stijn
c23b2d6e4f
Merge pull request #331 from docker/dependabot/github_actions/softprops/action-gh-release-2.0.8
...
build(deps): bump softprops/action-gh-release from 2.0.5 to 2.0.8
2024-10-25 13:49:14 +02:00
Sebastiaan van Stijn
13e62f3bbe
Dockerfile: update golangci-lint to v1.61.0
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-10-25 13:48:02 +02:00
Sebastiaan van Stijn
2d241f3602
Dockerfile: bump xx to v1.5.0
...
full diff: https://github.com/tonistiigi/xx/compare/v1.4.0...v1.5.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-10-25 13:47:42 +02:00
Sebastiaan van Stijn
58c87f0952
Merge pull request #341 from crazy-max/update-debian
...
dockerfile: update debian to bookworm
2024-10-25 13:46:27 +02:00
CrazyMax
dbb72e35c3
dockerfile: update debian to bookworm
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-10-25 12:41:21 +02:00
Sebastiaan van Stijn
6e5b45e59f
Merge pull request #328 from docker/dependabot/github_actions/docker/bake-action-5
...
build(deps): bump docker/bake-action from 4 to 5
2024-10-24 21:45:11 +02:00
dependabot[bot]
2ed5a274b6
build(deps): bump softprops/action-gh-release from 2.0.5 to 2.0.8
...
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release ) from 2.0.5 to 2.0.8.
- [Release notes](https://github.com/softprops/action-gh-release/releases )
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md )
- [Commits](https://github.com/softprops/action-gh-release/compare/69320dbe05506a9a39fc8ae11030b214ec2d1f87...c062e08bd532815e2082a85e87e3ef29c3e6d191 )
---
updated-dependencies:
- dependency-name: softprops/action-gh-release
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-07-19 09:38:39 +00:00
dependabot[bot]
7dbcc1c472
build(deps): bump docker/bake-action from 4 to 5
...
Bumps [docker/bake-action](https://github.com/docker/bake-action ) from 4 to 5.
- [Release notes](https://github.com/docker/bake-action/releases )
- [Commits](https://github.com/docker/bake-action/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: docker/bake-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-17 09:24:10 +00:00
Sebastiaan van Stijn
6b9df3ebb5
Merge pull request #323 from thaJeztah/pass_simplify_get
...
pass: Get: remove redundant stat
v0.8.2
2024-05-10 14:15:26 +02:00
Sebastiaan van Stijn
dc10c50685
Merge pull request #317 from docker/dependabot/github_actions/softprops/action-gh-release-2
...
build(deps): bump softprops/action-gh-release from 1 to 2
2024-05-10 14:14:16 +02:00
CrazyMax
896eb37d47
build(deps): bump softprops/action-gh-release to 2.0.5
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-05-10 11:04:52 +02:00
Sebastiaan van Stijn
a14669f4ff
pass: Get: remove redundant stat
...
listPassdir already handles "not found" errors, in which case it returns
an [empty result][1]. Previously this would return a custom error, but
since 1bb9aa3210 , an empty result produces
a `errCredentialsNotFound`, making this check redundant.
This patch removes the redundant check.
[1]: https://github.com/docker/docker-credential-helpers/blob/f64d6b131b3da07a6337dc63a882e08ce541d1c1/pass/pass.go#L118-L125
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-05-10 10:28:57 +02:00
Sebastiaan van Stijn
74840b3740
Merge pull request #322 from thaJeztah/pass_dry
...
pass: add utilities for encoding/decoding serverURL
2024-05-10 10:23:32 +02:00
Sebastiaan van Stijn
d3ef442f59
pass: add utilities for encoding/decoding serverURL
...
While the implementation of these is fairly trivial, we want them
to remain the same. This patch adds utilities to handle the encoding
and decoding of the server-URLs.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-05-09 16:58:34 +02:00
Sebastiaan van Stijn
f64d6b131b
Merge pull request #321 from thaJeztah/fix_pass_errors
...
pass: return correct error, and ignore empty stores on list
2024-05-09 16:44:30 +02:00
Sebastiaan van Stijn
1bb9aa3210
pass: return correct error, and ignore empty stores on list
...
commit 2fc2313bb1 changed the errors returned
by the pass credentials-helper to use a errCredentialsNotFound. This error
string is used in the client to distinguish a "not found" error from other
errors. (see [client.Get][1]).
However, there were additional second code-paths that returned a custom error,
which would not be detected as a "not found" error, resulting in an error when
logging out;
Removing login credentials for https://index.docker.io/v1/
WARNING: could not erase credentials:
https://index.docker.io/v1/ : error erasing credentials - err: exit status 1, out: `error getting credentials - err: exit status 1, out: `no usernames for https://index.docker.io/v1/ ``
This patch:
- updates Pass.Get() to return a errCredentialsNotFound if no credentials
were found
- updates Pass.List() to not return an error if any of the domains had no
credentials stored.
[1]: https://github.com/docker/docker-credential-helpers/blob/73b9e5d51f8dc9f598e08a0f2171c5d5a828e76b/client/client.go#L51-L55
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-05-09 12:19:23 +02:00
Sebastiaan van Stijn
73b9e5d51f
Merge pull request #320 from thaJeztah/update_gha
...
update GHA to macOS-13, macOS-14, and update to go1.21.10
2024-05-08 22:48:19 +02:00
Sebastiaan van Stijn
0c43fede6d
update to go1.21.10
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-05-08 15:59:23 +02:00
Sebastiaan van Stijn
a941c5247f
gha: update to use macos-13, macos-14
...
macos-11 runners are being deprecated; updating to use
macos-13 (x86) and macos-14 (arm64)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-05-08 15:56:13 +02:00
Sebastiaan van Stijn
097f945536
Merge pull request #318 from thaJeztah/pr_template
...
add pull-request template
2024-03-18 12:07:36 +01:00
Sebastiaan van Stijn
9272dcb90a
add pull-request template
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-03-18 11:17:06 +01:00
dependabot[bot]
ecacf8cdcf
build(deps): bump softprops/action-gh-release from 1 to 2
...
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release ) from 1 to 2.
- [Release notes](https://github.com/softprops/action-gh-release/releases )
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md )
- [Commits](https://github.com/softprops/action-gh-release/compare/de2c0eb89ae2a093876385947365aca7b0e5f844...d99959edae48b5ffffd7b00da66dcdb0a33a52ee )
---
updated-dependencies:
- dependency-name: softprops/action-gh-release
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-11 09:10:25 +00:00
Sebastiaan van Stijn
5be670a285
Merge pull request #316 from crazy-max/codecov-token
...
ci: set codecov token
2024-02-22 23:44:22 +01:00
CrazyMax
73aa8c0daa
ci: set codecov token
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-02-22 23:25:37 +01:00
Sebastiaan van Stijn
c23afb6c37
Merge pull request #313 from crazy-max/bump-gha
...
ci: update github actions to latest stable
2024-02-06 10:11:41 +01:00
CrazyMax
d622133060
Merge pull request #310 from thaJeztah/update_xx
...
Dockerfile: update xx to v1.4.0
2024-02-06 10:05:26 +01:00
CrazyMax
12500fb753
chore: dependabot to keep gha up to date
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-02-06 10:03:08 +01:00
CrazyMax
bf726a0656
ci: update github actions to latest stable
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-02-06 10:02:31 +01:00
Sebastiaan van Stijn
d9632f6a08
Dockerfile: update xx to v1.4.0
...
full diff: https://github.com/tonistiigi/xx/compare/v1.2.1...v1.4.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-02-06 09:55:36 +01:00
Sebastiaan van Stijn
292722b503
Merge pull request #308 from thaJeztah/update_golang_1.21.6
...
update to go1.21.6
v0.8.1
2024-01-10 18:01:53 +01:00
Sebastiaan van Stijn
979dcc4762
Merge pull request #309 from thaJeztah/update_golangci
...
Dockerfile: update golangci-lint to v1.55.2
2024-01-10 18:00:03 +01:00
Sebastiaan van Stijn
f411a65c31
Dockerfile: update golangci-lint to v1.55.2
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-10 16:18:18 +01:00
Sebastiaan van Stijn
9629bd77ad
update to go1.21.6
...
go1.20 is reaching EOL soon; let's update to the current version.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-10 14:42:35 +01:00
Sebastiaan van Stijn
f642c26173
Merge pull request #306 from thaJeztah/err_checks
...
move trimming whitespace to error-check helpers
2024-01-10 14:40:13 +01:00
Sebastiaan van Stijn
8fc330691f
Merge pull request #307 from thaJeztah/bump_wincred
...
vendor: github.com/danieljoos/wincred v1.2.1
2024-01-09 18:00:45 +01:00
Sebastiaan van Stijn
6a3e64c0b4
move trimming whitespace to error-check helpers
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-09 16:45:09 +01:00
Sebastiaan van Stijn
218f1787ac
vendor: github.com/danieljoos/wincred v1.2.1
...
- Credential Helpers [v0.8.0](https://github.com/docker/docker-credential-helpers/releases/tag/v0.8.0 )
full diff: https://github.com/danieljoos/wincred/compare/v1.2.0...v1.2.1
- Updated dependency golang.org/x/sys to version 0.15.0
- Updated dependency github.com/stretchr/testify to version 1.8.4
- Added error constant ErrBadUsername that can be used when dealing with domain password credentials.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-01-09 16:42:24 +01:00
Sebastiaan van Stijn
8396edb35f
Merge pull request #297 from thaJeztah/update_go_1.20.6
...
update go to go1.20.6, debian bullseye
v0.8.0
2023-07-17 02:13:55 +02:00
Sebastiaan van Stijn
a3d1ffcdb2
update go to go1.20.6
...
go1.20.6 (released 2023-07-11) includes a security fix to the net/http package,
as well as bug fixes to the compiler, cgo, the cover tool, the go command,
the runtime, and the crypto/ecdsa, go/build, go/printer, net/mail, and text/template
packages. See the Go 1.20.6 milestone on our issue tracker for details.
https://github.com/golang/go/issues?q=milestone%3AGo1.20.6+label%3ACherryPickApproved
Full diff: https://github.com/golang/go/compare/go1.20.5...go1.20.6
These minor releases include 1 security fixes following the security policy:
net/http: insufficient sanitization of Host header
The HTTP/1 client did not fully validate the contents of the Host header.
A maliciously crafted Host header could inject additional headers or entire
requests. The HTTP/1 client now refuses to send requests containing an
invalid Request.Host or Request.URL.Host value.
Thanks to Bartek Nowotarski for reporting this issue.
Includes security fixes for [CVE-2023-29406 ][1] and Go issue https://go.dev/issue/60374
[1]: https://github.com/advisories/GHSA-f8f7-69v5-w4vx
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2023-07-17 00:40:48 +02:00
Sebastiaan van Stijn
c03d56cfdc
deb: update to golang bullseye
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2023-07-17 00:40:29 +02:00
Sebastiaan van Stijn
7f484550bc
Merge pull request #294 from thaJeztah/use_designated_domains_step1
...
use designated domains in tests (RFC2606) (step 1)
2023-06-27 13:48:45 +02:00
Sebastiaan van Stijn
a90e3fa153
secretservice: use designated domains in tests (RFC2606)
...
Update domains used in tests to used domains that are designated for this
purpose as described in [RFC2606, section 3][1]
[1]: https://www.rfc-editor.org/rfc/rfc2606.html#section-3
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2023-06-26 13:59:01 +02:00
Sebastiaan van Stijn
ffb3232f6c
pass: use designated domains in tests (RFC2606)
...
Update domains used in tests to used domains that are designated for this
purpose as described in [RFC2606, section 3][1]
[1]: https://www.rfc-editor.org/rfc/rfc2606.html#section-3
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2023-06-26 13:59:01 +02:00
Sebastiaan van Stijn
1050848357
client: use designated domains in tests (RFC2606)
...
Update domains used in tests to used domains that are designated for this
purpose as described in [RFC2606, section 3][1]
[1]: https://www.rfc-editor.org/rfc/rfc2606.html#section-3
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2023-06-26 13:59:01 +02:00
Sebastiaan van Stijn
7d66ae02a6
osxkeychain: use designated domains in tests (RFC2606)
...
Update domains used in tests to used domains that are designated for this
purpose as described in [RFC2606, section 3][1]
[1]: https://www.rfc-editor.org/rfc/rfc2606.html#section-3
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2023-06-26 13:59:01 +02:00