8c804df56c
vendor: github.com/keybase/go-keychain v0.0.1
...
- removes pkg/errors as dependency
full diff: https://github.com/keybase/go-keychain/compare/7f41edfa9689...v0.0.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-02-27 19:19:36 +01:00
a7974e91c5
Merge pull request #282 from crazy-max/darwin-go-keychain
...
osxkeychain: switch to github.com/keybase/go-keychain
2025-02-27 18:35:34 +01:00
ffe5a9835c
ci: add macOS-15 to test matrix
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com >
2025-02-27 14:39:23 +01:00
e79a8203ca
osxkeychain: TestOSXKeychainHelperRetrieveAliases print err
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com >
2025-02-27 14:39:23 +01:00
4cdcdc29eb
osxkeychain: switch to github.com/keybase/go-keychain
...
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com >
2025-02-27 14:39:22 +01:00
8438667191
Merge pull request #357 from thaJeztah/bump_wincred
...
vendor: github.com/danieljoos/wincred v1.2.2
2025-02-27 14:38:31 +01:00
fc66c3f02c
Merge pull request #356 from WanzenBug/master
...
secretservice: fix null derefence on locked collections
2025-02-27 14:18:14 +01:00
7810dc4db9
vendor: github.com/danieljoos/wincred v1.2.2
...
- Bump golang.org/x/sys from 0.17.0 to 0.20.0
- Bump github.com/stretchr/testify from 1.8.4 to 1.9.0
- Added missing constant to sys_unsupported.go to avoid breaking builds on non-Windows platforms.
full diff: https://github.com/danieljoos/wincred/compare/v1.2.1...v1.2.2
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-02-27 13:07:17 +01:00
28e893e56d
secretservice: fix null derefence on locked collections
...
secret_item_get_secret() may return null if an item is locked or not loaded.
While we set SECRET_SEARCH_LOAD_SECRETS and SECRET_SEARCH_UNLOCK, there may
still be locked items, for example the user may refuse the unlock request.
So we still need to check if the secret data is NULL before we can try to
reference it.
Signed-off-by: Moritz "WanzenBug" Wanzenböck <moritz@wanzenbug.xyz >
2025-02-19 15:56:07 +01:00
1161e9c157
Merge pull request #353 from thaJeztah/bump_xx
...
Dockerfile: bump XX_VERSION to 1.6.1
2025-01-20 17:37:43 +01:00
a17e9a013b
Dockerfile: bump XX_VERSION to 1.6.1
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-01-20 16:54:10 +01:00
fe0e8e3a01
Merge pull request #324 from thaJeztah/carry_207_friendlier_labels
...
Set a better displaylabel for secretservice
2025-01-20 16:35:26 +01:00
c2ca986943
Set a better displaylabel for secretservice
...
Secretservice entries have a "label". This is intended to be a
human-readable description. It's actually called "Description" in UIs
like seahorse, and the listing of existing secrets shows this as a name
for each one.
The entries stored by the credential helper set this to simply the
repository URL. This is rather unfriendly, since entries like
"gitlab.com" and "index.docker.io/v1" show up. Mixed in with
entries from all other applications, it's hard to figure out what
application owns each entry.
This commit changes the label used when saving entries to be something
human-readable (this is the intent of the "label" field, btw). Because
of the naming scheme, this also results in all entries being shown
together by default (since UIs tend to sort lexicographically).
New entries will now be stores as:
Registry credentials for $REGISTRY_URL
Note that items stored by the secret service have multiple fields inside
of them. One of those fields is called "label", and is used by the
helper to filter items from the secret service. This "label" field is
entirely unrelated to the items' label. The naming is most unfortunate.
Signed-off-by: Hugo Osvaldo Barrera <hugo@barrera.io >
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2025-01-20 16:28:06 +01:00
407e50d36e
Merge pull request #352 from crazy-max/bake-v6
...
ci: update bake-action to v6
2025-01-13 22:28:27 +01:00
10845d8f94
Merge pull request #350 from docker/dependabot/github_actions/softprops/action-gh-release-2.2.1
...
build(deps): bump softprops/action-gh-release from 2.0.8 to 2.2.1
2025-01-10 11:00:25 +01:00
43ae7f3412
Merge pull request #345 from docker/dependabot/github_actions/codecov/codecov-action-5
...
build(deps): bump codecov/codecov-action from 4 to 5
2025-01-10 11:00:08 +01:00
1d9eaaa4ef
ci: fix deprecated codecov-action input
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2025-01-10 10:55:01 +01:00
7346714456
ci: update bake-action to v6
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2025-01-10 10:53:21 +01:00
ab3fc5283d
build(deps): bump softprops/action-gh-release from 2.0.8 to 2.2.1
...
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release ) from 2.0.8 to 2.2.1.
- [Release notes](https://github.com/softprops/action-gh-release/releases )
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md )
- [Commits](https://github.com/softprops/action-gh-release/compare/c062e08bd532815e2082a85e87e3ef29c3e6d191...c95fe1489396fe8a9eb87c0abf8aa5b2ef267fda )
---
updated-dependencies:
- dependency-name: softprops/action-gh-release
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-01-08 09:38:33 +00:00
713df50a2d
build(deps): bump codecov/codecov-action from 4 to 5
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4 to 5.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/codecov/codecov-action/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: codecov/codecov-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-11-15 10:06:35 +00:00
7e7c5576ba
Merge pull request #342 from thaJeztah/less_indirection
...
client: remove some indirection and touch-up GoDoc
2024-10-28 10:43:29 +01:00
ad253f54a5
client: remove some indirection and touch-up GoDoc
...
Both NewShellProgramFunc and NewShellProgramFuncWithEnv were using
createProgramCmdRedirectErr under the hood, but NewShellProgramFunc
had an extra indirection through NewShellProgramFuncWithEnv.
Make both a direct wrapper for createProgramCmdRedirectErr instead.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-10-25 14:41:30 +02:00
fa991bcbeb
Merge pull request #338 from thaJeztah/bump_golangci_lint
...
Dockerfile: update golangci-lint to v1.61.0
2024-10-25 14:22:44 +02:00
db1da9da5d
Merge pull request #339 from thaJeztah/bump_xx
...
Dockerfile: bump xx to v1.5.0
2024-10-25 13:54:32 +02:00
c23b2d6e4f
Merge pull request #331 from docker/dependabot/github_actions/softprops/action-gh-release-2.0.8
...
build(deps): bump softprops/action-gh-release from 2.0.5 to 2.0.8
2024-10-25 13:49:14 +02:00
13e62f3bbe
Dockerfile: update golangci-lint to v1.61.0
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-10-25 13:48:02 +02:00
2d241f3602
Dockerfile: bump xx to v1.5.0
...
full diff: https://github.com/tonistiigi/xx/compare/v1.4.0...v1.5.0
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-10-25 13:47:42 +02:00
58c87f0952
Merge pull request #341 from crazy-max/update-debian
...
dockerfile: update debian to bookworm
2024-10-25 13:46:27 +02:00
dbb72e35c3
dockerfile: update debian to bookworm
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-10-25 12:41:21 +02:00
6e5b45e59f
Merge pull request #328 from docker/dependabot/github_actions/docker/bake-action-5
...
build(deps): bump docker/bake-action from 4 to 5
2024-10-24 21:45:11 +02:00
2ed5a274b6
build(deps): bump softprops/action-gh-release from 2.0.5 to 2.0.8
...
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release ) from 2.0.5 to 2.0.8.
- [Release notes](https://github.com/softprops/action-gh-release/releases )
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md )
- [Commits](https://github.com/softprops/action-gh-release/compare/69320dbe05506a9a39fc8ae11030b214ec2d1f87...c062e08bd532815e2082a85e87e3ef29c3e6d191 )
---
updated-dependencies:
- dependency-name: softprops/action-gh-release
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-07-19 09:38:39 +00:00
7dbcc1c472
build(deps): bump docker/bake-action from 4 to 5
...
Bumps [docker/bake-action](https://github.com/docker/bake-action ) from 4 to 5.
- [Release notes](https://github.com/docker/bake-action/releases )
- [Commits](https://github.com/docker/bake-action/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: docker/bake-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-06-17 09:24:10 +00:00
6b9df3ebb5
Merge pull request #323 from thaJeztah/pass_simplify_get
...
pass: Get: remove redundant stat
2024-05-10 14:15:26 +02:00
dc10c50685
Merge pull request #317 from docker/dependabot/github_actions/softprops/action-gh-release-2
...
build(deps): bump softprops/action-gh-release from 1 to 2
2024-05-10 14:14:16 +02:00
896eb37d47
build(deps): bump softprops/action-gh-release to 2.0.5
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-05-10 11:04:52 +02:00
a14669f4ff
pass: Get: remove redundant stat
...
listPassdir already handles "not found" errors, in which case it returns
an [empty result][1]. Previously this would return a custom error, but
since 1bb9aa3210https://github.com/docker/docker-credential-helpers/blob/f64d6b131b3da07a6337dc63a882e08ce541d1c1/pass/pass.go#L118-L125
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-05-10 10:28:57 +02:00
74840b3740
Merge pull request #322 from thaJeztah/pass_dry
...
pass: add utilities for encoding/decoding serverURL
2024-05-10 10:23:32 +02:00
d3ef442f59
pass: add utilities for encoding/decoding serverURL
...
While the implementation of these is fairly trivial, we want them
to remain the same. This patch adds utilities to handle the encoding
and decoding of the server-URLs.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-05-09 16:58:34 +02:00
f64d6b131b
Merge pull request #321 from thaJeztah/fix_pass_errors
...
pass: return correct error, and ignore empty stores on list
2024-05-09 16:44:30 +02:00
1bb9aa3210
pass: return correct error, and ignore empty stores on list
...
commit 2fc2313bb1https://index.docker.io/v1/
WARNING: could not erase credentials:
https://index.docker.io/v1/ : error erasing credentials - err: exit status 1, out: `error getting credentials - err: exit status 1, out: `no usernames for https://index.docker.io/v1/ ``
This patch:
- updates Pass.Get() to return a errCredentialsNotFound if no credentials
were found
- updates Pass.List() to not return an error if any of the domains had no
credentials stored.
[1]: https://github.com/docker/docker-credential-helpers/blob/73b9e5d51f8dc9f598e08a0f2171c5d5a828e76b/client/client.go#L51-L55
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-05-09 12:19:23 +02:00
73b9e5d51f
Merge pull request #320 from thaJeztah/update_gha
...
update GHA to macOS-13, macOS-14, and update to go1.21.10
2024-05-08 22:48:19 +02:00
0c43fede6d
update to go1.21.10
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-05-08 15:59:23 +02:00
a941c5247f
gha: update to use macos-13, macos-14
...
macos-11 runners are being deprecated; updating to use
macos-13 (x86) and macos-14 (arm64)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-05-08 15:56:13 +02:00
097f945536
Merge pull request #318 from thaJeztah/pr_template
...
add pull-request template
2024-03-18 12:07:36 +01:00
9272dcb90a
add pull-request template
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl >
2024-03-18 11:17:06 +01:00
ecacf8cdcf
build(deps): bump softprops/action-gh-release from 1 to 2
...
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release ) from 1 to 2.
- [Release notes](https://github.com/softprops/action-gh-release/releases )
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md )
- [Commits](https://github.com/softprops/action-gh-release/compare/de2c0eb89ae2a093876385947365aca7b0e5f844...d99959edae48b5ffffd7b00da66dcdb0a33a52ee )
---
updated-dependencies:
- dependency-name: softprops/action-gh-release
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-03-11 09:10:25 +00:00
5be670a285
Merge pull request #316 from crazy-max/codecov-token
...
ci: set codecov token
2024-02-22 23:44:22 +01:00
73aa8c0daa
ci: set codecov token
...
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com >
2024-02-22 23:25:37 +01:00
c23afb6c37
Merge pull request #313 from crazy-max/bump-gha
...
ci: update github actions to latest stable
2024-02-06 10:11:41 +01:00
d622133060
Merge pull request #310 from thaJeztah/update_xx
...
Dockerfile: update xx to v1.4.0
2024-02-06 10:05:26 +01:00
Sebastiaan van Stijn