docker-credential-helpers/osxkeychain/osxkeychain_darwin_test.go

package osxkeychain

import (
	"fmt"
	"testing"

	"github.com/docker/docker-credential-helpers/credentials"
)

func TestOSXKeychainHelper(t *testing.T) {
	creds := &credentials.Credentials{
		ServerURL: "https://foobar.docker.io:2376/v1",
		Username:  "foobar",
		Secret:    "foobarbaz",
	}
	creds1 := &credentials.Credentials{
		ServerURL: "https://foobar.docker.io:2376/v2",
		Username:  "foobarbaz",
		Secret:    "foobar",
	}
	helper := Osxkeychain{}
	if err := helper.Add(creds); err != nil {
		t.Fatal(err)
	}

	username, secret, err := helper.Get(creds.ServerURL)
	if err != nil {
		t.Fatal(err)
	}

	if username != "foobar" {
		t.Fatalf("expected %s, got %s\n", "foobar", username)
	}

	if secret != "foobarbaz" {
		t.Fatalf("expected %s, got %s\n", "foobarbaz", secret)
	}

	auths, err := helper.List()
	if err != nil || len(auths) == 0 {
		t.Fatal(err)
	}

	helper.Add(creds1)
	defer helper.Delete(creds1.ServerURL)
	newauths, err := helper.List()
	if len(newauths)-len(auths) != 1 {
		if err == nil {
			t.Fatalf("Error: len(newauths): %d, len(auths): %d", len(newauths), len(auths))
		}
		t.Fatalf("Error: len(newauths): %d, len(auths): %d\n Error= %v", len(newauths), len(auths), err)
	}

	if err := helper.Delete(creds.ServerURL); err != nil {
		t.Fatal(err)
	}
}

// TestOSXKeychainHelperRetrieveAliases verifies that secrets can be accessed
// through variations on the URL
func TestOSXKeychainHelperRetrieveAliases(t *testing.T) {
	tests := []struct {
		doc      string
		storeURL string
		readURL  string
	}{
		{
			doc:      "stored with port, retrieved without",
			storeURL: "https://foobar.docker.io:2376",
			readURL:  "https://foobar.docker.io",
		},
		{
			doc:      "stored as https, retrieved without scheme",
			storeURL: "https://foobar.docker.io:2376",
			readURL:  "foobar.docker.io",
		},
		{
			doc:      "stored with path, retrieved without",
			storeURL: "https://foobar.docker.io:1234/one/two",
			readURL:  "https://foobar.docker.io:1234",
		},
	}

	helper := Osxkeychain{}
	defer func() {
		for _, tc := range tests {
			helper.Delete(tc.storeURL)
		}
	}()

	// Clean store before testing.
	for _, tc := range tests {
		helper.Delete(tc.storeURL)
	}

	for _, tc := range tests {
		c := &credentials.Credentials{ServerURL: tc.storeURL, Username: "hello", Secret: "world"}
		if err := helper.Add(c); err != nil {
			t.Errorf("Error: failed to store secret for URL %q: %s", tc.storeURL, err)
			continue
		}
		if _, _, err := helper.Get(tc.readURL); err != nil {
			t.Errorf("Error: failed to read secret for URL %q using %q", tc.storeURL, tc.readURL)
		}
		helper.Delete(tc.storeURL)
	}
}

// TestOSXKeychainHelperRetrieveStrict verifies that only matching secrets are
// returned.
func TestOSXKeychainHelperRetrieveStrict(t *testing.T) {
	tests := []struct {
		doc      string
		storeURL string
		readURL  string
	}{
		{
			doc:      "stored as https, retrieved using http",
			storeURL: "https://foobar.docker.io:2376",
			readURL:  "http://foobar.docker.io:2376",
		},
		{
			doc:      "stored as http, retrieved using https",
			storeURL: "http://foobar.docker.io:2376",
			readURL:  "https://foobar.docker.io:2376",
		},
		{
			// stored as http, retrieved without a scheme specified (hence, using the default https://)
			doc:      "stored as http, retrieved without scheme",
			storeURL: "http://foobar.docker.io",
			readURL:  "foobar.docker.io:5678",
		},
		{
			doc:      "non-matching ports",
			storeURL: "https://foobar.docker.io:1234",
			readURL:  "https://foobar.docker.io:5678",
		},
		// TODO: is this desired behavior? The other way round does work
		// {
		// 	doc:      "non-matching ports (stored without port)",
		// 	storeURL: "https://foobar.docker.io",
		// 	readURL:  "https://foobar.docker.io:5678",
		// },
		{
			doc:      "non-matching paths",
			storeURL: "https://foobar.docker.io:1234/one/two",
			readURL:  "https://foobar.docker.io:1234/five/six",
		},
	}

	helper := Osxkeychain{}
	defer func() {
		for _, tc := range tests {
			helper.Delete(tc.storeURL)
		}
	}()

	// Clean store before testing.
	for _, tc := range tests {
		helper.Delete(tc.storeURL)
	}

	for _, tc := range tests {
		c := &credentials.Credentials{ServerURL: tc.storeURL, Username: "hello", Secret: "world"}
		if err := helper.Add(c); err != nil {
			t.Errorf("Error: failed to store secret for URL %q: %s", tc.storeURL, err)
			continue
		}
		if _, _, err := helper.Get(tc.readURL); err == nil {
			t.Errorf("Error: managed to read secret for URL %q using %q, but should not be able to", tc.storeURL, tc.readURL)
		}
		helper.Delete(tc.storeURL)
	}
}

// TestOSXKeychainHelperStoreRetrieve verifies that secrets stored in the
// the keychain can be read back using the URL that was used to store them.
func TestOSXKeychainHelperStoreRetrieve(t *testing.T) {
	tests := []struct {
		url string
	}{
		{url: "foobar.docker.io"},
		{url: "foobar.docker.io:2376"},
		{url: "//foobar.docker.io:2376"},
		{url: "https://foobar.docker.io:2376"},
		{url: "http://foobar.docker.io:2376"},
		{url: "https://foobar.docker.io:2376/some/path"},
		{url: "https://foobar.docker.io:2376/some/other/path"},
		{url: "https://foobar.docker.io:2376/some/other/path?foo=bar"},
	}

	helper := Osxkeychain{}
	defer func() {
		for _, tc := range tests {
			helper.Delete(tc.url)
		}
	}()

	// Clean store before testing.
	for _, tc := range tests {
		helper.Delete(tc.url)
	}

	// Note that we don't delete between individual tests here, to verify that
	// subsequent stores/overwrites don't affect storing / retrieving secrets.
	for i, tc := range tests {
		c := &credentials.Credentials{
			ServerURL: tc.url,
			Username:  fmt.Sprintf("user-%d", i),
			Secret:    fmt.Sprintf("secret-%d", i),
		}

		if err := helper.Add(c); err != nil {
			t.Errorf("Error: failed to store secret for URL: %s: %s", tc.url, err)
			continue
		}
		user, secret, err := helper.Get(tc.url)
		if err != nil {
			t.Errorf("Error: failed to read secret for URL %q: %s", tc.url, err)
			continue
		}
		if user != c.Username {
			t.Errorf("Error: expected username %s, got username %s for URL: %s", c.Username, user, tc.url)
		}
		if secret != c.Secret {
			t.Errorf("Error: expected secret %s, got secret %s for URL: %s", c.Secret, secret, tc.url)
		}
	}
}

func TestMissingCredentials(t *testing.T) {
	const nonExistingCred = "https://adsfasdf.invalid/asdfsdddd"
	helper := Osxkeychain{}
	_, _, err := helper.Get(nonExistingCred)
	if !credentials.IsErrCredentialsNotFound(err) {
		t.Errorf("expected ErrCredentialsNotFound, got %v", err)
	}
	err = helper.Delete(nonExistingCred)
	if !credentials.IsErrCredentialsNotFound(err) {
		t.Errorf("expected ErrCredentialsNotFound, got %v", err)
	}
}